fix: fix min

supperchong · Mar 13, 2022 · 9bd33f9 · 9bd33f9
1 parent f4d3acc
commit 9bd33f9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/array.ts b/src/array.ts
@@ -372,7 +372,7 @@ export function min(...arg: number[] | number[][]): number {
     return Math.min(...arg)
   }
 
-  let min = -Infinity
+  let min = Infinity
 
   for (const num of arg) {
     min = Math.min(min, num)

diff --git a/test/array.test.ts b/test/array.test.ts
@@ -146,13 +146,25 @@ describe('test max', () => {
   it('should return the max value', () => {
     assert.strictEqual(max(1, 3, 2), 3)
   })
+  it('should return the max value when length is too large', () => {
+    let nums = Array(200000).fill(2)
+    nums[0] = 1
+    assert.throws(() => Math.max(...nums), RangeError)
+    assert.strictEqual(max(nums), 2)
+  })
 })
 
 describe('test min', () => {
   it('should return the min value', () => {
     assert.strictEqual(min(1, 3, 2), 1)
     assert.strictEqual(min([1, 3, 2]), 1)
   })
+  it('should return the min value when length is too large', () => {
+    let nums = Array(200000).fill(2)
+    nums[0] = 1
+    assert.throws(() => Math.min(...nums), RangeError)
+    assert.strictEqual(min(nums), 1)
+  })
 })
 
 describe('test unique', () => {