Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multithreaded bulk import #1043

Closed
wants to merge 172 commits into from

Conversation

tamassoltesz
Copy link
Contributor

@tamassoltesz tamassoltesz commented Sep 20, 2024

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your
changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here
highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
    • If there are any db schema changes, mention those changes clearly
  • coreDriverInterfaceSupported.json file has been updated (if needed)
  • pluginInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In build.gradle
  • If added a new paid feature, edit the getPaidFeatureStats function in FeatureFlag.java file
  • Had installed and ran the pre-commit hook
  • If there are new dependencies that have been added in build.gradle, please make sure to add them
    in implementationDependencies.json.
  • Update function getValidFields in io/supertokens/config/CoreConfig.java if new aliases were added for any core
    config (similar to the access_token_signing_key_update_interval config alias).
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the
      latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a foreign key constraint on app_id_to_user_id table, make sure to delete from this table when deleting
    the user as well if deleteUserIdMappingToo is false.

Remaining TODOs for this PR

  • Item1
  • Item2

virajkanwade and others added 30 commits May 20, 2024 12:04
* feat: Add an API to fetch the list of core config properties (#922)

* Add an API to fetch the coreConfig properties

* Update changelog

* Include plugin configs as well

* Remove core_config_result from the final output

* Hide protected config

* Fix formatting changes

* Add tests to ensure that the properties are same in the config and core config file

* Match descriptions from devConfig.yaml as well

* Refactor CoreConfig to return ConfigFieldInfo objects

* Refactor enum property validation

* Refactor move storage fields to API

* Refactor getConfigFieldsInfo method and update CoreConfigListAPI

* Add test to check protected properties are not present when saas secret is set

* Add comments wherever necessary

* fix: core config list

* fix: serialize nulls

* fix: is nullable

* fix: plugin configs

* fix: add new booleans for core config

* fix: cleanup

* fix: list apis

* fix: refactor config description

* fix: refactor cud tests

* fix: refactor tests

* fix: tests

* fix: type fix

* fix: flag setting for thirdparty providers

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: revert

* fix: tenant tests

* fix: app tests

* fix: cud tests

* fix: other tests

* fix: version and changelog

* fix: inmemory

* fix: skip deprecated

* fix: dashboard updates

* fix: minor fixes

* fix: tests

* fix: refactor

* fix: refactor

* fix: changelog

* fix: refactor

---------

Co-authored-by: Sattvik Chakravarthy <[email protected]>
Co-authored-by: Sattvik Chakravarthy <[email protected]>
* fix: tenant config

* fix: api permissions and telemetry update

* fix: totp length validation

* fix: accept api key via authorization header

* fix: cache control header for jwks endpoint

* fix: tests

* fix: for dashboard

* fix: remove unused import

* fix: remove unused import

* fix: providers non null

* fix: tests

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: improve core config normalisation

* fix: more tests

* fix: more tests

* fix: clean up core config

* fix: pr comments

* fix: more test

* reformates code

* reformats code

* fix: changelog and few other

* fix: test

* fix: supported versions

* fix: changelog

---------

Co-authored-by: Rishabh Poddar <[email protected]>
* fix: HideFromDashboard annotation

* fix: comment
porcellus and others added 28 commits October 29, 2024 12:56
* ci: try automatically re-running tests

* ci: try automatically re-running tests

* ci: try automatically re-running tests

* ci: try automatically re-running tests

* ci: try automatically re-running tests

* ci: try automatically re-running tests

* ci: try automatically re-running tests

* ci: try automatically re-running tests

* ci: try automatically re-running tests

* test: try and improve flaky tests

* chore: changelog consistency with plugin

* feat: make deep-links work
test: enable/fix rerun failed test on ci-cd
@tamassoltesz tamassoltesz deleted the branch feat/bulk-import-1 November 27, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants