Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RND-314-audit-logs-cleaning-background-task #1545

Merged
merged 2 commits into from
Dec 21, 2023
Merged

RND-314-audit-logs-cleaning-background-task #1545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d62e3dd
audit-logs-cleaning-background-task
shohamroditimemphis Dec 20, 2023
034fe98
change name to RemoveOldProducersAndConsumersAndAuditLogs
shohamroditimemphis Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions db/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,6 +1099,26 @@ func RemoveAuditLogsByTenant(tenantName string) error {
return nil
}

func RemoveAuditLogsByTenantAndCreatedAt(tenantName string, createdAt time.Time) error {
ctx, cancelfunc := context.WithTimeout(context.Background(), DbOperationTimeout*time.Second)
defer cancelfunc()
conn, err := MetadataDbClient.Client.Acquire(ctx)
if err != nil {
return err
}
defer conn.Release()
query := `DELETE FROM audit_logs WHERE tenant_name = $1 AND created_at < $2`
stmt, err := conn.Conn().Prepare(ctx, "remove_audit_logs_by_tenant_and_created_at", query)
if err != nil {
return err
}
_, err = conn.Conn().Query(ctx, stmt.Name, tenantName, createdAt)
if err != nil {
return err
}
return nil
}

// Station Functions
func GetActiveStationsPerTenant(tenantName string) ([]models.Station, error) {
ctx, cancelfunc := context.WithTimeout(context.Background(), DbOperationTimeout*time.Second)
Expand Down
11 changes: 8 additions & 3 deletions server/background_tasks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ func (s *Server) StartBackgroundTasks() error {
go s.InitializeThroughputSampling()
go s.UploadTenantUsageToDB()
go s.RefreshFirebaseFunctionsKey()
go s.RemoveOldProducersAndConsumers()
go s.RemoveOldProducersAndConsumersAndAuditLogs()
go ScheduledCloudCacheRefresh()
go s.SendBillingAlertWhenNeeded()
go s.CheckBrokenConnectedIntegrations()
Expand Down Expand Up @@ -616,14 +616,19 @@ func (s *Server) RemoveOldDlsMsgs() {
}
}

func (s *Server) RemoveOldProducersAndConsumers() {
func (s *Server) RemoveOldProducersAndConsumersAndAuditLogs() {
ticker := time.NewTicker(15 * time.Minute)
for range ticker.C {
for tenantName, rt := range s.opts.GCProducersConsumersRetentionHours {
configurationTime := time.Now().Add(time.Hour * time.Duration(-rt))
err := db.DeleteOldProducersAndConsumers(configurationTime, tenantName)
if err != nil {
serv.Errorf("[tenant: %v]RemoveOldProducersAndConsumers at DeleteOldProducersAndConsumers : %v", tenantName, err.Error())
serv.Errorf("[tenant: %v]RemoveOldProducersAndConsumersAndAuditLogs at DeleteOldProducersAndConsumers : %v", tenantName, err.Error())
}
time := time.Now().Add(-time.Hour * 3 * 24)
err = db.RemoveAuditLogsByTenantAndCreatedAt(tenantName, time)
if err != nil {
serv.Errorf("[tenant: %v]RemoveOldProducersAndConsumersAndAuditLogs at RemoveAuditLogsByTenantAndCreatedAt : %v", tenantName, err.Error())
}
}
}
Expand Down