Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable create version to existing schema via sdk #1496

Merged
merged 3 commits into from
Dec 10, 2023
Merged

enable create version to existing schema via sdk #1496

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14c1167
enable create version to existing schema via sdk
shohamroditimemphis Dec 8, 2023
207fca7
changes
shohamroditimemphis Dec 9, 2023
364425b
fix logs
shohamroditimemphis Dec 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions server/memphis_handlers_schemas.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,16 +939,15 @@ func (s *Server) updateSchemaVersion(schemaID int, tenantName string, newSchemaR
s.Errorf("[tenant: %v][user: %v]updateSchemaVersion at db.GetShcemaVersionsCount: Schema %v: %v", tenantName, user.Username, newSchemaReq.Name, err.Error())
return err
}

_, currentSchema, err := db.GetSchemaVersionByNumberAndID(countVersions, schemaID)
if err != nil {
s.Errorf("[tenant: %v][user: %v]updateSchemaVersion at db.GetSchemaVersionByNumberAndID: Schema %v: %v", tenantName, user.Username, newSchemaReq.Name, err.Error())
return err
}

if currentSchema.SchemaContent == newSchemaReq.SchemaContent {
alreadyExistInDB := fmt.Sprintf("%v already exist in the db", newSchemaReq.Name)
s.Warnf("[tenant: %v][user: %v]at updateSchemaVersion, %v already exist in the db", tenantName, user.Username, newSchemaReq.Name)
alreadyExistInDB := fmt.Sprintf("%v already exists in the db with the same schema content", newSchemaReq.Name)
s.Warnf("[tenant: %v][user: %v]at updateSchemaVersion, %v already exists in the db with the same schema content", tenantName, user.Username, newSchemaReq.Name)
return errors.New(alreadyExistInDB)
}

Expand Down