Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rnd 1191 remove superstream compression enabled env var #193

Merged

Conversation

shay23b
Copy link
Contributor

@shay23b shay23b commented Oct 31, 2024

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Enable/Disable compression
  • Enable/Disable debug mode and see log Superstream library has been loaded

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the knowledge base (if needed)
  • My changes generate no new warnings
  • I have verified that the specification is met and all functionalities are working as expected
  • I resolved conflicts

Reviewer Score - 100%

  • Meeting Task Specifications (50%)

    • This includes both UI design and backend functionality.
    • Ensure that the task requirements are fully met and that the implementation aligns with the specifications provided.
  • Attention to Edge Cases (10%)

    • Identify and handle edge cases that may not be immediately obvious.
    • Demonstrate thorough testing and consideration of potential issues.
  • Writing Performant and Efficient Code (10%)

    • Optimize the code for performance and efficiency.
    • Avoid unnecessary computations and strive for optimal resource usage.
  • Addressing Feedback from Previous Code Reviews (10%)

    • Act on feedback provided in previous code reviews.
    • Show improvement and a proactive approach to learning from past reviews.
  • Adherence to Coding Conventions (5%)

    • Follow the established coding standards and guidelines.
    • Maintain consistency in style and structure throughout the codebase.
  • Writing Readable Code (5%)

    • Write code that is easy to read and understand.
    • Use clear and meaningful variable names, and include comments where necessary.
  • Considering Aspects Not Explicitly Mentioned in the Specification (5%)

    • Demonstrate initiative by considering aspects that may not be explicitly mentioned in the task specification.
    • Enhance the implementation by thinking beyond the basic requirements.
  • Completing Pull Request Form (2.5%)

    • Demonstrate initiative by considering aspects that may not be explicitly mentioned in the task specification.
    • Enhance the implementation by thinking beyond the basic requirements.
  • Up to 2 Cycles of Code Review (2.5%)

    • Engage in up to two cycles of code review to refine and improve the code.
    • Incorporate suggestions and resolve any identified issues.

@shay23b shay23b changed the base branch from 3.5.1 to 3.5.1-beta October 31, 2024 08:58
@shay23b shay23b merged commit 2e1953c into 3.5.1-beta Oct 31, 2024
shay23b added a commit that referenced this pull request Oct 31, 2024
* remove SUPERSTREAM_COMPRESSION_ENABLED

* add static log when debug is true

* move static inside superstream

* beta version

* remove not needed code

* beta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants