[RND-1019] Parse received optimized configs #191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the issue where optimised config is sent to client and the client doesn't recognise the type properly causing it to crash. All digits were treated as ints and class names as strings. This change cast appropriate properties to long, short and class.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
The code has been compiled in Jenkins pipeline to a .jar file. That file has been included to my local testing project that uses the lib to create clients. I tried many different configs including ones to be treated as short, long and class by the lib.
Checklist:
Reviewer Score - 100%
Meeting Task Specifications (50%)
Attention to Edge Cases (10%)
Writing Performant and Efficient Code (10%)
Addressing Feedback from Previous Code Reviews (10%)
Adherence to Coding Conventions (5%)
Writing Readable Code (5%)
Considering Aspects Not Explicitly Mentioned in the Specification (5%)
Completing Pull Request Form (2.5%)
Up to 2 Cycles of Code Review (2.5%)