Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SuperEditor][Web] Fix option + arrow key selection changes (Resolves #2415) #2418

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[SuperEditor][Web] Fix option + arrow key selection changes (Resolves #2415) #2418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b6f5ec
[SuperEditor][Web] Fix option + arrow key selection changes (Resolves…
angelosilvestre Nov 20, 2024
c1cc0ac
Fix test comment
angelosilvestre Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...r_editor/lib/src/default_editor/document_hardware_keyboard/document_keyboard_actions.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,8 @@ ExecutionInstruction doNothingWithLeftRightArrowKeysAtMiddleOfTextOnWeb({
return ExecutionInstruction.continueExecution;
}

if (defaultTargetPlatform == TargetPlatform.windows && HardwareKeyboard.instance.isAltPressed) {
if ((defaultTargetPlatform == TargetPlatform.windows || CurrentPlatform.isApple) &&
HardwareKeyboard.instance.isAltPressed) {
return ExecutionInstruction.continueExecution;
}

Expand Down
120 changes: 120 additions & 0 deletions super_editor/test/super_editor/supereditor_input_keyboard_actions_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,126 @@ void main() {
),
);
});

testWidgetsOnMacDesktopAndWeb('SHIFT + OPTION + LEFT ARROW: removes upstream word from selection',
(tester) async {
await tester //
.createDocument()
.withCustomContent(
MutableDocument(
nodes: [
ParagraphNode(
id: '1',
text: AttributedText('This is a paragraph'),
),
],
),
)
.pump();

// Place caret at the beginning of the paragraph.
await tester.placeCaretInParagraph('1', 0);

// Press CMD + SHIFT + RIGHT ARROW to expand the selection to the end of the line.
await tester.pressShiftCmdRightArrow();

// Ensure that the whole line is selected.
expect(
SuperEditorInspector.findDocumentSelection(),
selectionEquivalentTo(
const DocumentSelection(
base: DocumentPosition(
nodeId: "1",
nodePosition: TextNodePosition(offset: 0),
),
extent: DocumentPosition(
nodeId: "1",
nodePosition: TextNodePosition(offset: 19),
),
),
),
);

// Press SHIFT + OPTION + LEFT ARROW to remove the last word from the selection.
await tester.pressShiftAltLeftArrow();

// Ensure that the last word was removed from the selection.
expect(
SuperEditorInspector.findDocumentSelection(),
selectionEquivalentTo(
const DocumentSelection(
base: DocumentPosition(
nodeId: "1",
nodePosition: TextNodePosition(offset: 0),
),
extent: DocumentPosition(
nodeId: "1",
nodePosition: TextNodePosition(offset: 10),
),
),
),
);
});

testWidgetsOnMacDesktopAndWeb('SHIFT + OPTION + RIGHT ARROW: removes downstream word from selection',
(tester) async {
await tester //
.createDocument()
.withCustomContent(
MutableDocument(
nodes: [
ParagraphNode(
id: '1',
text: AttributedText('This is a paragraph'),
),
],
),
)
.pump();

// Place caret at the end of the paragraph.
await tester.placeCaretInParagraph('1', 19);

// Press CMD + SHIFT + LEFT ARROW to expand the selection to the beginning of the line.
await tester.pressShiftCmdLeftArrow();

// Ensure that the whole line is selected.
expect(
SuperEditorInspector.findDocumentSelection(),
selectionEquivalentTo(
const DocumentSelection(
base: DocumentPosition(
nodeId: "1",
nodePosition: TextNodePosition(offset: 19),
),
extent: DocumentPosition(
nodeId: "1",
nodePosition: TextNodePosition(offset: 0),
),
),
),
);

// Press SHIFT + OPTION + RIGHT ARROW to remove the first word from the selection.
await tester.pressShiftAltRightArrow();

// Ensure that the first word was removed from the selection.
expect(
SuperEditorInspector.findDocumentSelection(),
selectionEquivalentTo(
const DocumentSelection(
base: DocumentPosition(
nodeId: "1",
nodePosition: TextNodePosition(offset: 19),
),
extent: DocumentPosition(
nodeId: "1",
nodePosition: TextNodePosition(offset: 4),
),
),
),
);
});
});

group("Windows and Linux >", () {
Expand Down
Loading