Adding flutter_lints

[domesticmouse]

Hey @matthew-carroll,

I tried adding flutter_lints, but the tests are failing. However, the reason is unmigrated code in the spikes directory, so I'm unsure what you want to do about that.

brett

[matthew-carroll]

I'll look through this. It's probably time to delete the spikes.

One thing I'm noticing is a possible line-length difference. I have mine set to 120 in the IDE. Do you know if there's a way to set that in the lint rules? I think 80 is too short.

[domesticmouse]

I'll reformat for 120

[domesticmouse]

Looks like configuring Dartfmt's line length is a non-starter: dart-lang/dart_style#918

I'd suggest adding a check to your Github Actions that checks if a dart format with line length of 120 changes things. Happy to add it to this PR if ya want.

[matthew-carroll]

I'd suggest adding a check to your Github Actions that checks if a dart format with line length of 120 changes things. Happy to add it to this PR if ya want.

Sure, if you know where/how to add that then I'd say go for it. Thanks.

[domesticmouse]

Pulled the 120 char line length change into a separate PR: #229

[matthew-carroll]

@domesticmouse it looks like a number of tests broke with this PR. Any idea why?

[domesticmouse]

Looks like I constified lists that shouldn't have been consted. I'll re-run locally and debug.

[domesticmouse]

Tests now pass locally. Hopefully it should also pass in CI.

[domesticmouse]

Non-netlify tests pass. No idea why the netlify tests are failing.

Halp?

[matthew-carroll]

The website build failures are unrelated to this, we can ignore them. I'll merge this in.