-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VDB Matrix: Vendor Data #44
Conversation
…nal sheet & the vendor json files. Validation and sync to Vercel Blob Storage missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to use the new schema for the github action, that will have to be modified as well. It's currently using docs/tools/vdb_table/data/vendor.schema.json
and not docs/tools/vdb_table/vendor.schema.json
@mamayer19 thanks that helped. However I introduced a regression: I saw this trigger locally also, but can't tell why stringWithSource wouldn't succeed validation - it's declared the same way as everything else in that schema. |
I think you are referencing these wrong. It should work with:
My bet is that none of the others work either, this is the first it hits and it exits the validation. There's only |
I see the fix worked for the validation, so I only have 1 remaining suggestion: I highly advise against using spaces in file names, I'd rather convert everything to snake case. Spaces cause notoriously annoying issues all the time on *nix-like systems. |
…e the filenames for the JSONs.
@mamayer19 nice good point, fixed |
…vendor JSON properties have the same order as schema properties.
Context:
This PR contains:
The front-end and github->front-end sync parts will be delivered in separate PRs in parallel to this one.