hotfix: Open deeplink callbacks in current tab even in iframe use case #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etharner
approved these changes
Oct 5, 2020
mradkov
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverts #495
The thing is that window.parent is always truthy:
https://developer.mozilla.org/en-US/docs/Web/API/Window/parent
Would be better to use IN_FRAME the next time. Forcing openUrl to use a new tab in the web version of wallet breaks deeplink flow. To address #493 I'm proposing explicitly specify that the explorer and ui should be opened in a new tab, but keeping the ability to open deeplink in the same tab that is used in Meet.
closes aeternity/jitsi-meet#259