Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add react version @aeternity/superhero-button/react #21

Closed
shapkarin opened this issue Jul 14, 2020 · 6 comments
Closed

Add react version @aeternity/superhero-button/react #21

shapkarin opened this issue Jul 14, 2020 · 6 comments

Comments

@shapkarin
Copy link
Contributor

shapkarin commented Jul 14, 2020 •
edited
Loading

Make that repo a part of this one. To make it easier to integrate button in any kind of projects that use sdk.
Not only our jitsi or forks
@davidyuk
Copy link
Member

related issue: #11

@shapkarin
Copy link
Contributor Author

@davidyuk so we agree to add React and maybe later Vue as part of this repo and npm package but at separate folders and without export to the main?

@shapkarin shapkarin mentioned this issue Aug 25, 2020
Open
@davidyuk
Copy link
Member

davidyuk commented Aug 25, 2020 •
edited
Loading

Yes, I think so.
aeternity/superhero-button-react#2 (comment)

@shapkarin
Copy link
Contributor Author

Yes, I think so.

OK. I will do that after the aeternity/jitsi-meet#166

@shapkarin shapkarin reopened this Sep 8, 2020
@shapkarin
Copy link
Contributor Author

sorry, thought that it's duplicate

@davidyuk davidyuk mentioned this issue Oct 22, 2020
Closed
@davidyuk
Copy link
Member

davidyuk commented Dec 2, 2020

implemented in #38 🎉

@davidyuk davidyuk closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add react tip button superhero-com/superhero-utils
2 participants
@shapkarin @davidyuk