Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React component #11

Closed
shapkarin opened this issue Jun 19, 2020 · 6 comments
Closed

React component #11

shapkarin opened this issue Jun 19, 2020 · 6 comments

Comments

@shapkarin
Copy link
Contributor

It will be nice to have a react component wrapper. I can help with that.

@davidyuk
Copy link
Member

davidyuk commented Jun 20, 2020

Would be nice to implement it without explicit dependency on react (like a functional component?)

@shapkarin
Copy link
Contributor Author

shapkarin commented Jun 21, 2020

@davidyuk I see two ways:

  • change this project API to fit with react and create react component next
  • create react's one from scratch

I need this for that integration and I'm afraid that my current integration with this lib can cause problems with garbage collector.

@shapkarin
Copy link
Contributor Author

shapkarin commented Jun 21, 2020

@davidyuk let's decide what will be better for a future maintaining. Also I can to help with that task #4

@davidyuk
Copy link
Member

change this project API to fit with react

What is the issue here? I think it is already implemented in a way compatible with React/Vue and other use cases.

I'm afraid that my current integration with this lib can cause problems with garbage collector

Can you send a link exactly to that integration for review? Won't superhero-button be collected after removing the corresponding node from DOM?

@shapkarin
Copy link
Contributor Author

shapkarin commented Jun 22, 2020

What is the issue here? I think it is already implemented in a way compatible with React/Vue and other use cases.

There is no issue. I think think to export some methods to make them available.

Can you send a link exactly to that integration for review? Won't superhero-button be collected after removing the corresponding node from DOM?

You can check the current integration at:
aeternity/jitsi-meet@jwt_with_detector...aeternity:tip_button

@shapkarin
Copy link
Contributor Author

@davidyuk I use call superheroButton every time when speaker changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants