[ETHEREUM-CONTRACTS] Disable flownfts

[d10r]

See #1993

deploy-framework.js won't deploy FlowNFT contracts anymore. But it will preserve existing contract addresses if set.

Note that only enough code to keep the CI pipeline green was removed, there's still a lot of FlowNFT related code left.
As is in this PR, it would be relatively easy to "bring it back" later.
In order to fully purge, a lot more code locations need to be touched.

piggy-backed:

• include previous canonical superTokenLogic in list of logic addresses to be updated from

[github-actions]

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

• CHANGELOG.md modified
• Double check before merge

[hellwolf]

• remove eNFT completely from code base
• Remove all eNFT references in ISuperToken
• Make sure deployment scripts no longer dependent on the eNFT interfaces.

[hellwolf]

to be released as v1.11.0

[kasparkallas]

Only the FlowNFT handling of the event disappears, right, not MetadataUpdate altogether?

[d10r]

didn't realize this is FlowNFT specific too. So, yes, I guess more pruning...

[d10r]

removed now

[d10r]

removal of an event / attributes (?) will break getEvents() in sdk-core.
Thus this order of events is important:

• create new sdk-core package and update products
• switch canonical subgraph to new schema

[d10r]

reason for docker-compose -> docker compose: actions/runner-images#9692

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.55%. Comparing base (5106c44) to head (d9743c3).

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1991      +/-   ##
==========================================
- Coverage   88.63%   88.55%   -0.08%     
==========================================
  Files         119      111       -8     
  Lines        7388     6945     -443     
  Branches      981      933      -48     
==========================================
- Hits         6548     6150     -398     
+ Misses        838      793      -45     
  Partials        2        2              

Flag	Coverage Δ
ethereum-contracts	94.76% <ø> (+0.53%)	⬆️
sdk-core	88.55% <100.00%> (-0.08%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hellwolf]

$ git grep -i flownft packages/ | wc -l
97

$ git grep -i flownft packages/ | grep -Fv CHANGELOG.md | head -n10
packages/ethereum-contracts/contracts/mocks/SuperTokenFactoryMock.t.sol:import { SuperTokenFactoryBase, IConstantOutflowNFT, IConstantInflowNFT } from "../superfluid/SuperTokenFactory.sol";
packages/ethereum-contracts/contracts/mocks/SuperTokenFactoryMock.t.sol:        IConstantOutflowNFT constantOutflowNFT,
packages/ethereum-contracts/contracts/mocks/SuperTokenFactoryMock.t.sol:        IConstantInflowNFT constantInflowNFT,
packages/ethereum-contracts/contracts/mocks/SuperTokenFactoryMock.t.sol:        SuperTokenFactoryBase(host, superTokenLogic, constantOutflowNFT, constantInflowNFT, poolAdminNFT, poolMemberNFT)
packages/ethereum-contracts/contracts/mocks/SuperTokenFactoryMock.t.sol:        IConstantOutflowNFT constantOutflowNFT,
packages/ethereum-contracts/contracts/mocks/SuperTokenFactoryMock.t.sol:        IConstantInflowNFT constantInflowNFT,
packages/ethereum-contracts/contracts/mocks/SuperTokenFactoryMock.t.sol:        SuperTokenFactoryBase(host, superTokenLogic, constantOutflowNFT, constantInflowNFT, poolAdminNFT, poolMemberNFT)
packages/ethereum-contracts/contracts/mocks/SuperTokenFactoryMock.t.sol:        IConstantOutflowNFT constantOutflowNFT,
packages/ethereum-contracts/contracts/mocks/SuperTokenFactoryMock.t.sol:        IConstantInflowNFT constantInflowNFT,
packages/ethereum-contracts/contracts/mocks/SuperTokenFactoryMock.t.sol:        SuperTokenFactoryBase(host, superTokenLogic, constantOutflowNFT, constantInflowNFT, poolAdminNFT, poolMemberNFT)

$...

What are these remnants?

[d10r]

The currently deployed Supertoken.sol has this in updateCode():

        // @note This is another check to ensure that when updating to a new SuperToken logic contract
        // that we have passed the correct NFT proxy contracts in the construction of the new SuperToken
        // logic contract
        if (
            CONSTANT_OUTFLOW_NFT !=
            SuperToken(newAddress).CONSTANT_OUTFLOW_NFT() ||
            CONSTANT_INFLOW_NFT !=
            SuperToken(newAddress).CONSTANT_INFLOW_NFT()
        ) {
            revert SUPER_TOKEN_NFT_PROXY_ADDRESS_CHANGED();
        }

So we can't set the address to zero in this upgrade, meaning we can't fully prune in 1 iteration.
This PR removes this check, so in a next iteration we could complete the pruning.

Also I already removed CONSTANT_OUTFLOW_NFT() and CONSTANT_OUTFLOW_NFT() from ISuperToken.

[hellwolf]

:) great!

[github-actions]

XKCD Comic Relif

Link: https://xkcd.com/1991