[WIP] feat: add crm/contracts for pipedrive #372
Conversation
mladibejn
force-pushed
the
feat/crm/pipedrive
branch
from
810d5dd
to
4fbc04f
Compare
| superface.run({ | ||
| useCase: 'Create', | ||
| input: { | ||
| email: '[email protected]', |
There was a problem hiding this comment.
It's best practice to use example.com or example.org for such purposes; that way, you can also avoid some potential spam on your domain 😅
|
|
||
| return { | ||
| title = "Unknown error" | ||
| detail = `Unknown error occurred. Status: ${statusCode}. IPData provider error info: ${detail}.` |
| } | ||
| } | ||
|
|
||
| operation GetOrCreateOrganizatio { |
There was a problem hiding this comment.
| operation GetOrCreateOrganizatio { | |
| operation GetOrCreateOrganization { |
|
|
||
| operation GetOrCreateOrganizatio { | ||
|
|
||
| data = call GetOrganizationByName(input = args.input) |
There was a problem hiding this comment.
This way of calling ends up silently throwing away the error if the operation call fails, see:
https://superface.ai/docs/comlink/reference/map#calling-operation
This may be useful in some cases - but here it may result in e.g. creating duplicate organizations, in case the operation falls intermittently, or due to some other reason.
It'd be best to use the "Calling with a handler" syntax (documented in the link above)
| @@ -57,3 +57,5 @@ superface/grid | |||
|
|
|||
| # Superface compiled capabilities | |||
| grid/**/*.ast.json | |||
|
|
|||
| .idea | |||
There was a problem hiding this comment.
This probably shouldn't be a part of this PR? :)
(Also, I assume you're using WebStorm for the TypeScript part?)
| body = { | ||
| name: [input.firstName, input.lastName].join(" "), | ||
| email: [{ | ||
| label: "", |
There was a problem hiding this comment.
| label: "", |
Please note that only value is required.
Probably best to remove, if there's no reason to keep it
|
|
||
| }], | ||
| phone: [{ | ||
| label: "", |
There was a problem hiding this comment.
| label: "", |
Ditto
| } | ||
| } | ||
|
|
||
| organization = call GetOrCreateOrganizatio(input = input) |
There was a problem hiding this comment.
| organization = call GetOrCreateOrganizatio(input = input) | |
| organization = call GetOrCreateOrganization(input = input) |
There was a problem hiding this comment.
This ends up silently throwing away the error, see https://superface.ai/docs/comlink/reference/map#calling-operation
| } | ||
| } | ||
|
|
||
| // https://developers.pipedrive.com/docs/api/v1/Persons#searchPersons |
There was a problem hiding this comment.
Once again, ❤️ for linking the docs :)
|
|
||
| request "application/json" { | ||
| query { | ||
| // operator does not exist |
There was a problem hiding this comment.
| // operator does not exist | |
| // PipeDrive doesn't support search operators |
Description
This PR adds Pipedrive provider and impl. of use cases for crm/contracts profile
Motivation and Context
Types of changes
Checklist: