Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle undefined and null in form-data field value #342

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

freaz
Copy link
Member

@freaz freaz commented Apr 14, 2023

Description

Fields with value null or undefined are not sent, as they are not convertible to string or Blob.

Motivation and Context

Internally reported bug.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly. If you are changing code related to user secrets you need to really make sure that security documentation is correct.
  • I have read the CONTRIBUTING document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@freaz freaz requested a review from TheEdward162 April 14, 2023 08:24
@freaz freaz force-pushed the fix/formdata_with_undefined_as_field_value branch from 5ec9f82 to 95d2b7e Compare April 14, 2023 08:34
@freaz freaz merged commit e67227a into main Apr 17, 2023
@freaz freaz deleted the fix/formdata_with_undefined_as_field_value branch April 17, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants