Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input validation to work with None values #334

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Conversation

freaz
Copy link
Member

@freaz freaz commented Feb 14, 2023

Description

This adds proper validation of input and it emulates inputs based on presence in profile.

This is temporary fix as the best is to wrap input structure to NoneNull already in parser. Which I will do in next iteration.

Also I needed to change passed values in one test which did pass object even though nothing should be passed. Exactly we are doing this change. To make clearer what is validated.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly. If you are changing code related to user secrets you need to really make sure that security documentation is correct.
  • I have read the CONTRIBUTING document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@TheEdward162 TheEdward162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, as we discussed on Slack

@freaz freaz merged commit be46882 into main Feb 15, 2023
@freaz freaz deleted the fix/undefined_input branch February 15, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants