Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing comment in sandbox expression shouldn't breake it #327

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Trailing comment in sandbox expression shouldn't breake it #327

merged 1 commit into from
Jan 30, 2023

Conversation

freaz
Copy link
Member

@freaz freaz commented Jan 27, 2023

Description

Safer sandbox, but better eval expression.

Motivation and Context

Potentially this could break Comlink Script expression's evaluation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly. If you are changing code related to user secrets you need to really make sure that security documentation is correct.
  • I have read the CONTRIBUTING document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@freaz freaz force-pushed the fix/trailing_comment_in_vm_expression branch from 786e340 to ba37745 Compare January 27, 2023 14:38
@freaz freaz force-pushed the fix/trailing_comment_in_vm_expression branch from ba37745 to f0c1a62 Compare January 27, 2023 14:44
@freaz freaz merged commit ef8418e into dev Jan 30, 2023
@freaz freaz deleted the fix/trailing_comment_in_vm_expression branch January 30, 2023 08:35
@freaz freaz mentioned this pull request Jan 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheEdward162 TheEdward162 TheEdward162 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freaz @TheEdward162