Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/nullable enum validation #312

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Fix/nullable enum validation #312

merged 3 commits into from
Dec 21, 2022

Conversation

Jakub-Vacek
Copy link
Member

Description

Fixes: #311

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly. If you are changing code related to user secrets you need to really make sure that security documentation is correct.
  • I have read the CONTRIBUTING document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

TheEdward162
TheEdward162 approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@TheEdward162 TheEdward162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think other things might need the same treatment (arrays, for example) as well. I'll try to fix those.

src/core/interpreter/profile-parameter-validator.ts Outdated Show resolved Hide resolved
@Jakub-Vacek Jakub-Vacek merged commit 7a34907 into dev Dec 21, 2022
@Jakub-Vacek Jakub-Vacek deleted the fix/nullable-enum-validation branch December 21, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheEdward162 TheEdward162 TheEdward162 approved these changes

@freaz freaz Awaiting requested review from freaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] nullable enum input validation
2 participants
@Jakub-Vacek @TheEdward162