Align with OneSDK@3 #107
Draft
Align with OneSDK@3 #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freaz
force-pushed
the
feat/update_provider_json
branch
from
1cc6728
to
4dd3826
Compare
freaz
changed the title
freaz
force-pushed
the
feat/update_provider_json
branch
from
4dd3826
to
e79149c
Compare
freaz
force-pushed
the
feat/update_provider_json
branch
from
e79149c
to
7542b87
Compare
freaz
commented
Jul 19, 2023
Comment on lines
58
to
65
| "bodyType": { | ||
| "$id": "ApiKeyBodyType", | ||
| "description": "Body type to inject security value to.", | ||
| "enum": [ | ||
| "json" | ||
| ], | ||
| "type": "string" | ||
| }, |
There was a problem hiding this comment.
Some dark magic happening here. Compared to ApiKeyPlacement if I use $ref on the field, it will be still created in place but with id and ref, so there is circular reference. And I am unable to convince typescript-json-schema library to generate ApiKeyBodyType in definitions. 🤷
freaz
changed the title
freaz
force-pushed
the
feat/update_provider_json
branch
from
9208fd0
to
d9743f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This needs to be major release of AST.
For changes see CHANGELOG
Todo
ApiKeySecuritySchemeand havebodyTyperequired fortype: "body".Fighting typescript-json-schema lib
Motivation and Context
Makes
assertProviderJsonto behave as expectedTypes of changes
Checklist: