Fix issues after TreeSelect is unmounted #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzonidoo
approved these changes
Jun 6, 2023
| && (this.openDropdownRef.current?.contains(event.target as HTMLElement) !== true) | ||
| ) { | ||
| this.setState({openDropdown: false}); | ||
| onMouseDown = (event: MouseEvent) => { |
There was a problem hiding this comment.
FYI this is not a class method, but a public class field and doesn't need binding. It also works a bit differently than methods in more complex case like inheritance. It also has a negative performance impact that might be significant or not depending on usage. Because of this and the fact that didn't fully investigate the feature I prefer using class methods. It might be worth looking into it in the future since it allows for shorter code in some cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.