Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement extension point for copy embed #880

Merged
merged 11 commits into from
Apr 16, 2024

Conversation

petrjasek
Copy link
Member

@petrjasek petrjasek commented Apr 10, 2024

replaces #873

Checklist

  • This pull request is not adding new forms that use redux
  • This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence
  • This pull request is replacing lodash.get with optional chaining for modified code segments

@petrjasek petrjasek added this to the v2.7 milestone Apr 10, 2024
assets/ui/components/ArticleBodyHtml.tsx Outdated Show resolved Hide resolved
assets/ui/components/ArticleBodyHtml.tsx Outdated Show resolved Hide resolved
assets/ui/components/ArticleBodyHtml.tsx Outdated Show resolved Hide resolved
@MarkLark86
Copy link
Contributor

@petrjasek If a new version of the article is published to Newshub, does the preview automatically update? I believe this used to happen, but I'm not sure if that will work anymore.

@petrjasek
Copy link
Member Author

petrjasek commented Apr 12, 2024

@MarkLark86 seems like we're not doing any auto update until user clicks on the refresh button

@petrjasek petrjasek merged commit cb37e8e into superdesk:develop Apr 16, 2024
7 checks passed
@petrjasek petrjasek deleted the copy-embed-to-clipboard branch April 16, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants