Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: working on IOS #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update: working on IOS #11

wants to merge 1 commit into from

Conversation

jaakidup
Copy link

@jaakidup jaakidup commented Nov 2, 2017

This is basically working on IOS now, I changed a bit of the styling as I was playing with the updated though, so you decide what you want.

@supachailllpay
Copy link
Owner

supachailllpay commented Nov 3, 2017

Thank you very much I'll take a look soon. #10

@supachailllpay
Copy link
Owner

Hi @jaakidup thanks again. I already check your code and I found

In
css: You restyle some background-color (and modify toolbar style which didn't use in html).
html: You remove the toolbar and move a back button inside slideshow.
javascript: Not much changed.

So I still no idea which part of code solve the bug your described. Did I missed something here?

Thanks.

@jaakidup
Copy link
Author

jaakidup commented Nov 3, 2017 via email

@supachailllpay
Copy link
Owner

supachailllpay commented Nov 5, 2017

Hi @jaakidup. Sorry for my late reply.

Yes, of course I did.

I found there's not much change in css and javascript which mean it has nothing to do with the problem. Is that correct?

Your remove the toolbar and bring the back button inside slide show, that means if we only remove toolbar it will solve the problem?

You said slide and toolbar not being displayed, what about slideshow? at least it should have black background not white.

I don't want to be annoying. I just want to make sure what's the real cause of this problem and I really appreciate your time thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants