Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/impersonate user #59

Closed
wants to merge 4 commits into from
Closed

Feat/impersonate user #59

wants to merge 4 commits into from

Conversation

egor-romanov
Copy link

What kind of change does this PR introduce?

  • add impersonate user draft

@olirice
Copy link
Collaborator

olirice commented Nov 15, 2023

I'm hesitant on this one because its supabase specific and (so far) the goal of this project was to provide a vector-db client-like experience for any postgres instance pgvector.

some other options for apis might be

with vecs.create_client(DB_CONNECTION, {}) as vx: # where {} is a generic settings group
    # do something

or in the short term we could document

with docs.client.Session() as sess:
    sess.execute(...) # settings go here
    docs .... # operations go here

(I think) that'll work on SQLA 2.0 since begin_nested is now automatic

@egor-romanov
Copy link
Author

I'm hesitant on this one because its supabase specific and (so far) the goal of this project was to provide a vector-db client-like experience for any postgres instance pgvector.

I am thinking if we can somehow make it as an extension instead. So that it will be easy to use with RLS (as it seems to be a thing people looking for).

Even right now it doesn't break anything, but of course auth.uid() and all request.jwt.claim are very specific to Supabase.

What if we can add this the similar way it is done for adapters? But i think it should have some good generic placement in the call pipeline

@olirice
Copy link
Collaborator

olirice commented Nov 16, 2023

similar way it is done for adapters

that could work. would you be able to spec out what you had in mind as an issue?

@olirice
Copy link
Collaborator

olirice commented Dec 5, 2023

closing for now

@olirice olirice closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants