Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update poetry.lock; Remove dataclasses dependency #353

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

ShantanuNair
Copy link
Contributor

  • Dataclasses is no longer needed. It is a dependency needed only for Python < 3.7. Realtime, however requires Python >= 3.7, and so this dep isn't needed.

What kind of change does this PR introduce?

Additional context

- Dataclasses is no longer needed. It is a dependency needed only for Python < 3.7. Realtime, however requires Python >= 3.7, and so this dep isn't needed.
  - Already removed in realtime supabase/realtime-py#48
- Fixes supabase#33 (comment) This issue comes up when using this library in AWS Lambda with serverless framework plugin serverless-python-requirements and this lock file makes it hard to deploy to Lambda with environments Python >= 3.7.
@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Base: 78.98% // Head: 78.98% // No change to project coverage 👍

Coverage data is based on head (398a0a3) compared to base (202c070).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #353   +/-   ##
========================================
  Coverage    78.98%   78.98%           
========================================
  Files            9        9           
  Lines          157      157           
========================================
  Hits           124      124           
  Misses          33       33           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@J0 J0 self-requested a review January 28, 2023 03:55
@J0 J0 merged commit e62e95d into supabase:develop Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ERROR] AttributeError: module 'typing' has no attribute '_ClassVar', supabase-py on AWS Lambda
2 participants