Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update supabase_dart version #22

Merged
merged 4 commits into from
Sep 15, 2021
Merged

chore: update supabase_dart version #22

merged 4 commits into from
Sep 15, 2021

Conversation

dshukertjr
Copy link
Member

@dshukertjr dshukertjr commented Sep 14, 2021

What kind of change does this PR introduce?

This PR will update supabase_dart to v0.2.6, which includes the X-Client-Info header.

Some of the small changes such as adding commas or reordering imports are done because of the new lint rule in dart 2.14.0.

Closes supabase/supabase-dart#45

What is the current behavior?

supabase_flutter does not override supabase_dart header

What is the new behavior?

supabase_flutter will override supabase_dart header

@dshukertjr dshukertjr marked this pull request as ready for review September 14, 2021 11:18
@bdlukaa
Copy link
Collaborator

bdlukaa commented Sep 14, 2021

I don't think this is necessary

@bdlukaa
Copy link
Collaborator

bdlukaa commented Sep 14, 2021

We already have it on supabase_dart. There's no point on doing it here. It'll only complicate our lives in the future.

Just upgrade the supabase-dart version

@dshukertjr
Copy link
Member Author

@bdlukaa Thanks! Makes sense! Let me revert that change!

@dshukertjr dshukertjr changed the title chore: add X-Client-Info header chore: update supabase_dart version Sep 14, 2021
Copy link
Collaborator

@bdlukaa bdlukaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dshukertjr dshukertjr merged commit 6260ac3 into supabase:main Sep 15, 2021
@dshukertjr dshukertjr deleted the chore/x-client-info branch September 15, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X-Client-Info header
2 participants