Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add small fixes to v0.4.0 #34

Merged
merged 4 commits into from
Jul 5, 2024
Merged

fix: add small fixes to v0.4.0 #34

merged 4 commits into from
Jul 5, 2024

Commits on Jul 3, 2024

  1. fix: set cookies when mfa challenge is verified (#27)

    ## What kind of change does this PR introduce?
    
    Currently, create server client doesn't seem to set cookies when MFA
    Challenge is verified
    J0 authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    c217f53 View commit details
    Browse the repository at this point in the history
  2. fix: update conventional commits ci to use main instead of master (#31)

    ## What kind of change does this PR introduce?
    
    As per title
    J0 authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    bebce89 View commit details
    Browse the repository at this point in the history
  3. fix: set cookies for password recovery event (#32)

    ## What kind of change does this PR introduce?
    
    Bug fix
    
    ## What is the current behavior?
    
    When resetting a user's password with an email template which has a URL
    defining the `type` value as `recovery`, and using the `verifyOtp`
    method to process the token_hash and type, the SSR server client's
    `onAuthStateChange` function does not recognize the `PASSWORD_RECOVERY`
    event that verifyOtp fires. This prevents the code
    [here](https://github.com/supabase/ssr/blob/main/src/createServerClient.ts#L199-L205)
    from running; resulting in the new session not being saved to cookies,
    and the user is not considered logged in.
    
    Fixes #21
    
    ## What is the new behavior?
    
    User is logged in.
    
    ## Additional context
    
    Replaces PR #24
    
    Co-authored-by: Jason Creviston <[email protected]>
    j4w8n and j4w8n-malynium authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    7dc1837 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. feat: update CI so it runs on release as well (#33)

    ## What kind of change does this PR introduce?
    
    so that we can unblock v0.4.1. Referencing the Auth workflow:
    https://github.com/supabase/auth/blob/master/.github/workflows/test.yml
    J0 authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    4517996 View commit details
    Browse the repository at this point in the history