Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make non-default args non-null in UDFs #446

Merged
merged 2 commits into from
Nov 7, 2023
Merged

fix: make non-default args non-null in UDFs #446

merged 2 commits into from
Nov 7, 2023

Conversation

imor
Copy link
Contributor

@imor imor commented Nov 7, 2023

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Non-default arguments to UDFs are exposed as nullable.

What is the new behavior?

Non-default arguments to UDFS are exposed as non-null.

Additional context

Fixes #444

Copy link
Contributor

@olirice olirice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, could you pls add an entry to the changelog for this before merging?

@imor imor merged commit 853ad4a into master Nov 7, 2023
4 checks passed
@imor imor deleted the issue_444 branch November 7, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In UDF should function arguments with no default be not null e.g. someFunc(arg: UUID!) vs someFunc(arg: UUID)
2 participants