Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: diff auth and storage config on link #2894

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Nov 16, 2024

What kind of change does this PR introduce?

feature

What is the new behavior?

Diff configs by merging mgmt-api response to local struct.

WARNING: Project status is RESTORING instead of Active Healthy. Some operations might fail.
Enter your database password (or leave blank to skip):
Finished supabase link.
WARNING: Local config differs from linked project. Try updating supabase/config.toml
diff supabase/config.toml ljkpogxamxkdhowzcjvo
--- supabase/config.toml
+++ ljkpogxamxkdhowzcjvo
@@ -2,7 +2,7 @@

 [api]
 enabled = true
-schemas = ["public", "graphql_public"]
+schemas = ["public", "storage", "graphql_public"]

Additional context

A simpler change than #2895

@sweatybridge sweatybridge force-pushed the link-remote branch 2 times, most recently from b5f3666 to 0334311 Compare November 16, 2024 10:47
@coveralls
Copy link

coveralls commented Nov 16, 2024

Pull Request Test Coverage Report for Build 11906908759

Details

  • 42 of 51 (82.35%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 59.524%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/link/link.go 42 51 82.35%
Files with Coverage Reduction New Missed Lines %
internal/link/link.go 1 73.43%
internal/utils/tenant/database.go 10 0.0%
Totals Coverage Status
Change from base Build 11868418312: -0.1%
Covered Lines: 6381
Relevant Lines: 10720

💛 - Coveralls

@sweatybridge sweatybridge merged commit 8dbf6b2 into develop Nov 19, 2024
9 checks passed
@sweatybridge sweatybridge deleted the link-remote branch November 19, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants