Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: email templates for monorepos #2723

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

avallete
Copy link
Member

@avallete avallete commented Oct 2, 2024

What kind of change does this PR introduce?

fs.ValidatePath won't work for paths starting with ../. Fallback to using fs.Stat instead.

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Fixes: #2721

@avallete avallete requested a review from a team as a code owner October 2, 2024 10:32
@avallete avallete force-pushed the avallete/fix-email-templates-monorepo branch from ff96879 to 0541ec3 Compare October 2, 2024 10:35
@coveralls
Copy link

coveralls commented Oct 4, 2024

Pull Request Test Coverage Report for Build 11182980302

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 59.976%

Files with Coverage Reduction New Missed Lines %
internal/debug/postgres.go 3 64.86%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 11176899559: -0.06%
Covered Lines: 6448
Relevant Lines: 10751

💛 - Coveralls

Copy link
Contributor

@sweatybridge sweatybridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick

pkg/config/config.go Show resolved Hide resolved
@sweatybridge sweatybridge merged commit 333a2ca into develop Oct 4, 2024
9 checks passed
@sweatybridge sweatybridge deleted the avallete/fix-email-templates-monorepo branch October 4, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in configuring email templates within a monorepo
3 participants