Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support delete all credentials from keyring #2671

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Sep 11, 2024

What kind of change does this PR introduce?

feature

What is the new behavior?

Extend keyring to delete all credentials on all platforms.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner September 11, 2024 05:39
@coveralls
Copy link

coveralls commented Sep 11, 2024

Pull Request Test Coverage Report for Build 10813817559

Details

  • 11 of 22 (50.0%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 60.017%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/utils/credentials/store.go 0 3 0.0%
internal/utils/credentials/keyring_linux.go 11 19 57.89%
Files with Coverage Reduction New Missed Lines %
internal/projects/create/create.go 2 34.88%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 10811179040: -0.07%
Covered Lines: 6384
Relevant Lines: 10637

💛 - Coveralls

Copy link
Member

@avallete avallete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed much less code than my version 😅

I'll refactor my PR for linux and osx on my branch to match it.

Also I've opened a PR over the go-keyring package: zalando/go-keyring#112 which has been looked at.

With a bit of luck we won't have too keep maintaining that for long 👍

@sweatybridge sweatybridge changed the title feat: support delete all credentials on windows feat: support delete all credentials from keyring Sep 11, 2024
@sweatybridge sweatybridge force-pushed the win-keyring branch 3 times, most recently from b2461c3 to 9c98577 Compare September 11, 2024 07:20
@sweatybridge sweatybridge force-pushed the win-keyring branch 2 times, most recently from c4eccf6 to b05e885 Compare September 11, 2024 14:32
@sweatybridge sweatybridge merged commit 6003aae into develop Sep 11, 2024
16 checks passed
@sweatybridge sweatybridge deleted the win-keyring branch September 11, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants