Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: db reset with disabled services #2663

Conversation

avallete
Copy link
Member

@avallete avallete commented Sep 9, 2024

What kind of change does this PR introduce?

When performing the "reset db" check against the config to find "enabled" services and only restart the ones that are enabled. Also only "seed storage" service if the storage service is actually enabled.

What is the current behavior?

Fixes #2658

What is the new behavior?

  • Make "restartServices" only restart enabled services
  • Skip the bucket seeding phase if "storage" service isn't enabled.

In terms of output there should be no differences.

Additional context

@avallete avallete requested a review from a team as a code owner September 9, 2024 10:16
@coveralls
Copy link

coveralls commented Sep 9, 2024

Pull Request Test Coverage Report for Build 10774975567

Details

  • 0 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 60.017%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/db/reset/reset.go 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 89.53%
Totals Coverage Status
Change from base Build 10699758747: -0.006%
Covered Lines: 6363
Relevant Lines: 10602

💛 - Coveralls

@sweatybridge sweatybridge merged commit 8a50b02 into supabase:develop Sep 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

supabase db reset fails if storage is disabled
3 participants