Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add secure password change config #2643

Conversation

silentworks
Copy link
Contributor

What kind of change does this PR introduce?

This feature can be found in the Supabase Hosted Dashboard but doesn't have a way to configure it in the config.toml.

What is the current behavior?

No way to set Secure password change

What is the new behavior?

Can now set Secure password change in the config.toml file.

Additional context

Add any other context or screenshots.

@silentworks silentworks requested a review from a team as a code owner August 30, 2024 00:14
@coveralls
Copy link

coveralls commented Aug 30, 2024

Pull Request Test Coverage Report for Build 10627700876

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 59.994%

Files with Coverage Reduction New Missed Lines %
internal/debug/postgres.go 3 64.86%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 10530811862: -0.05%
Covered Lines: 6360
Relevant Lines: 10601

💛 - Coveralls

@J0
Copy link
Contributor

J0 commented Aug 30, 2024

Probably don't need a test in config_test.go for this one since it should load similarly to the other auth config variables

Co-authored-by: Joel Lee <[email protected]>
@sweatybridge sweatybridge merged commit 89bc764 into supabase:develop Aug 30, 2024
9 checks passed
@sweatybridge
Copy link
Contributor

Thanks for patching and reviewing!

@github-actions github-actions bot mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants