Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): add external_url while a replacement is found for auth/studio #2634

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

StanGirard
Copy link
Contributor

@StanGirard StanGirard commented Aug 23, 2024

Fixes #2527

Currently, the external_api_url is not read from the config.toml.

I know there is an ongoing subject about mutualizing auth/studio url but it requires too much changes.

This is a quick fix that improves the features of the CLI without removing any

@StanGirard StanGirard requested a review from a team as a code owner August 23, 2024 17:27
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10529825124

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 59.972%

Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 5 83.72%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 10506225474: -0.08%
Covered Lines: 6357
Relevant Lines: 10600

💛 - Coveralls

Copy link
Contributor

@sweatybridge sweatybridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, agree this is a good interim solution. Thanks for contributing!

@sweatybridge sweatybridge merged commit 8fa065f into supabase:develop Aug 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the API_EXTERNAL_URL used by the gotrue service to be set
3 participants