Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove uniq to avoid data corruption (#2632) #2633

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

tmountain
Copy link
Contributor

What kind of change does this PR introduce?

This resolves:

#2632

What is the current behavior?

The current behavior is that contiguous unique data in sql dumps is removed (corrupting data).

Please link any relevant issues here.

#2632

What is the new behavior?

The new behavior is that contiguous data is preserved.

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10529444371

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 59.991%

Files with Coverage Reduction New Missed Lines %
internal/debug/postgres.go 3 64.86%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 10506225474: -0.06%
Covered Lines: 6359
Relevant Lines: 10600

💛 - Coveralls

Copy link
Contributor

@sweatybridge sweatybridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for the thorough investigation and fix!

@sweatybridge sweatybridge merged commit 9c1f9f2 into supabase:develop Aug 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants