Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use batch object upload api #2598

Merged
merged 4 commits into from
Aug 9, 2024
Merged

fix: use batch object upload api #2598

merged 4 commits into from
Aug 9, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Aug 8, 2024

What kind of change does this PR introduce?

follow up #2591

What is the new behavior?

Exposes batch upserts api for reuse.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner August 8, 2024 12:05
@sweatybridge sweatybridge changed the title fix: add batch object upload api fix: use batch object upload api Aug 8, 2024
@sweatybridge sweatybridge force-pushed the batch-object branch 2 times, most recently from fd879cb to b3295f3 Compare August 8, 2024 14:47
@coveralls
Copy link

coveralls commented Aug 8, 2024

Pull Request Test Coverage Report for Build 10313766096

Details

  • 22 of 26 (84.62%) changed or added relevant lines in 4 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 60.08%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/bootstrap/bootstrap.go 0 1 0.0%
internal/seed/buckets/buckets.go 5 6 83.33%
internal/storage/cp/cp.go 10 12 83.33%
Files with Coverage Reduction New Missed Lines %
internal/seed/buckets/buckets.go 1 69.23%
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 10281335502: -0.08%
Covered Lines: 6333
Relevant Lines: 10541

💛 - Coveralls

@sweatybridge sweatybridge force-pushed the batch-object branch 2 times, most recently from b86dcd8 to 725a35c Compare August 8, 2024 15:15
@sweatybridge sweatybridge merged commit f676aa8 into develop Aug 9, 2024
9 checks passed
@sweatybridge sweatybridge deleted the batch-object branch August 9, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants