Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(functions): always resolve absolute path in container #2187

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Apr 18, 2024

What kind of change does this PR introduce?

Bug fix #1338

What is the new behavior?

  • Always use absolute path in generated import map when serving inside edge runtime, because import map must be mounted at /home/deno instead of /home/deno/functions
  • Rewrite windows path separator to unix for mounting in container.
  • Avoid duplicate mount point when both --import-map flag and functions/import_map.json are used.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner April 18, 2024 21:00
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8744606755

Details

  • 12 of 15 (80.0%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 57.889%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/utils/deno.go 8 9 88.89%
internal/functions/serve/serve.go 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
internal/utils/deno.go 2 54.96%
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 8731797751: -0.03%
Covered Lines: 6428
Relevant Lines: 11104

💛 - Coveralls

@sweatybridge sweatybridge merged commit f262424 into develop Apr 18, 2024
9 checks passed
@sweatybridge sweatybridge deleted the fix-import branch April 18, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

supabase functions serve: Import maps fail to resolve inside of 'functions' directory
2 participants