Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset prompt defaults to true for CI environments #1437

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Aug 30, 2023

What kind of change does this PR introduce?

follow up #1392

What is the new behavior?

CI environments do not evaluate to terminal, hence the default value is used without prompting.

This PR allows running db reset --db-url ... in CI.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner August 30, 2023 02:46
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6020009299

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 56.477%

Files with Coverage Reduction New Missed Lines %
internal/db/reset/reset.go 2 77.57%
internal/gen/keys/keys.go 5 12.31%
Totals Coverage Status
Change from base Build 6020008500: -0.05%
Covered Lines: 4848
Relevant Lines: 8584

💛 - Coveralls

@sweatybridge sweatybridge merged commit 8a68f11 into main Aug 30, 2023
10 checks passed
@sweatybridge sweatybridge deleted the prompt-default branch August 30, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants