Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass down jwt secret as database config #1432

Merged
merged 2 commits into from
Aug 29, 2023
Merged

fix: pass down jwt secret as database config #1432

merged 2 commits into from
Aug 29, 2023

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Aug 28, 2023

What kind of change does this PR introduce?

related to supabase/supabase#16681

What is the current behavior?

PGRST_APP_SETTINGS_* only sets the option only for PostgREST transaction. For feature parity with platform, we set it at database level.

What is the new behavior?

Set the database config via init sql.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner August 28, 2023 16:54
@coveralls
Copy link

coveralls commented Aug 28, 2023

Pull Request Test Coverage Report for Build 6009935228

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 56.532%

Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.31%
Totals Coverage Status
Change from base Build 5998183932: -0.03%
Covered Lines: 4842
Relevant Lines: 8565

💛 - Coveralls

@sweatybridge sweatybridge merged commit 1522d23 into main Aug 29, 2023
8 checks passed
@sweatybridge sweatybridge deleted the jwt-config branch August 29, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants