-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable JWT verification when serving all functions #1005
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4655797259
💛 - Coveralls |
laktek
force-pushed
the
use-edge-runtime-1.2
branch
from
April 10, 2023 01:18
5fab1ef
to
116109f
Compare
laktek
commented
Apr 10, 2023
Thanks for fixing those @soedirgo. Shall we merge this and do a follow up PR for per function configs? |
Yea sounds good. |
sweatybridge
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What is the current behavior?
No JWT verification when serving all functions via
supabase function serve
.What is the new behavior?
Serving all functions will default to verify JWT unless
--no-verify-jwt
flag is passed.Additional context
Fixes #873.
Also, the new version of edge-runtime should include
Deno.errors
(as mentioned in the ticket supabase/edge-runtime#211)Tested
supabase start
and it also seems to work.