Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change Dockerfile.dev target from netlify to Supabase #973

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

J0
Copy link
Contributor

@J0 J0 commented Feb 15, 2023

Further renaming from netlify -> Supabase. Main change here is on the dev set up - if one cleans out existing image + volumes + cache and runs make dev the build step will error with "Failed to load configuration: open .env.docker: no such file or directory as Docker will look in /go/src/github.com/netlify/gotrue instead of /go/src/github.com/supabase/gotrue

@J0 J0 requested a review from a team as a code owner February 15, 2023 09:12
@J0 J0 changed the title fix: Change dev dockerfile from netlify to Supabase fix: Change Dockerfile.dev target from netlify to Supabase Feb 15, 2023
Copy link
Contributor

@hf hf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch I forgot to update this.

@J0 J0 merged commit ee74d52 into master Feb 15, 2023
@J0 J0 deleted the j0/fix_docker_setup branch February 15, 2023 09:45
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.51.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
)

Further renaming from netlify -> Supabase. Main change here is on the
dev set up - if one cleans out existing image + volumes + cache and runs
`make dev` the build step will error with `"Failed to load
configuration: open .env.docker: no such file or directory` as Docker
will look in `/go/src/github.com/netlify/gotrue` instead of
`/go/src/github.com/supabase/gotrue`

---------

Co-authored-by: [email protected] <[email protected]>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
)

Further renaming from netlify -> Supabase. Main change here is on the
dev set up - if one cleans out existing image + volumes + cache and runs
`make dev` the build step will error with `"Failed to load
configuration: open .env.docker: no such file or directory` as Docker
will look in `/go/src/github.com/netlify/gotrue` instead of
`/go/src/github.com/supabase/gotrue`

---------

Co-authored-by: [email protected] <[email protected]>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
)

Further renaming from netlify -> Supabase. Main change here is on the
dev set up - if one cleans out existing image + volumes + cache and runs
`make dev` the build step will error with `"Failed to load
configuration: open .env.docker: no such file or directory` as Docker
will look in `/go/src/github.com/netlify/gotrue` instead of
`/go/src/github.com/supabase/gotrue`

---------

Co-authored-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants