feat: add has verified factor mfa claim #1838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
commented
Nov 13, 2024
| @@ -108,6 +108,7 @@ type AccessTokenClaims struct { | |||
| AuthenticatorAssuranceLevel string `json:"aal,omitempty"` | |||
| AuthenticationMethodReference []models.AMREntry `json:"amr,omitempty"` | |||
| SessionId string `json:"session_id,omitempty"` | |||
| HasVerifiedFactor bool `json:"has_verified_factor"` | |||
There was a problem hiding this comment.
Should be set to false if there are no factors / nil slice so there's no need for an omitempty specifier
Pull Request Test Coverage Report for Build 11811241578Details
💛 - Coveralls |
J0
changed the title
kangmingtay
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
@J0 can we also add a test to check that the value in the claim is expected?
kangmingtay
reviewed
Nov 13, 2024
| @@ -108,6 +108,7 @@ type AccessTokenClaims struct { | |||
| AuthenticatorAssuranceLevel string `json:"aal,omitempty"` | |||
| AuthenticationMethodReference []models.AMREntry `json:"amr,omitempty"` | |||
| SessionId string `json:"session_id,omitempty"` | |||
| HasVerifiedFactor bool `json:"has_verified_factor"` | |||
There was a problem hiding this comment.
should we call this mfa_enabled ? seems easier to understand vs has_verified_factor?
cstockton
requested changes
Nov 13, 2024
|
Currently we don't use The above convention would work though though we'd need to make an exception for MFA methods:
|
|
Closing in favour of documentation, should evaluate RFC8176 at some point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Supercedes #1823 and adds a
HasVerifiedFactorclaim so that it's easier to enforce aal2 only if MFA is enabled on a user's account. Naming is open for discussionAdditional context
Internally, prior to deploy, we will need to update tests (if any) to reflect that we have added a new claim. As this is an additive change, it should not break any existing setups