Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vue demi to support Vue2 and Vue3 #5

Merged
merged 22 commits into from
Jul 25, 2021

Conversation

sduduzog
Copy link
Collaborator

@sduduzog sduduzog commented Jul 16, 2021

What kind of change does this PR introduce?

Chore: A conditional check for a VueJS version. This attempts to use https://github.com/vueuse/vue-demi as mentioned in #2

What is the current behavior?

Package only supports use in VueJS V2

What is the new behavior?

  • Includes support for Vue3
  • Exposes useSupabase possible through the provide/inject api
  • For Vue 2.x users will have to also install @vue/composition-api

Additional context

This has been manually tested against a Vue 2.x, Vue 3.x (with vue cli and vite) and a nuxt project with a nuxt-supabase fork

@sduduzog sduduzog changed the title Use vue demi to support Vue2 and Vue3 (WIP) Use vue demi to support Vue2 and Vue3 Jul 25, 2021
@sduduzog
Copy link
Collaborator Author

Finally comfortable with this PR @scottrobertson

I also updated the README with the changes in usage

@scottrobertson
Copy link
Contributor

scottrobertson commented Jul 25, 2021

Thanks @sduduzog.

I am guessing there is no way around having to use @vue/composition-api for Vue2 users? Since that is quite the breaking change. If not, it's fine as I can just tag this as 2.x but yeah... would be awesome if we can find a way without.

@NuroDev do you have any suggestions around that?

@NuroDev
Copy link

NuroDev commented Jul 25, 2021

Nope, all looks good to me 👍🏻

@scottrobertson
Copy link
Contributor

Nope, all looks good to me 👍🏻

Thank you.

@sduduzog have you done any integration testing already for Nuxt-Supabase yet or should I do that?

@sduduzog
Copy link
Collaborator Author

@scottrobertson I have, in a private repo. All works well, still with the composition-api being a prerequisite.

@sduduzog
Copy link
Collaborator Author

I still recommend you test too, I'll create a PR for nuxt-supabase with this branch

@scottrobertson scottrobertson merged commit dfe1b7f into supabase-community:main Jul 25, 2021
@sduduzog sduduzog deleted the use-vue-demi branch November 1, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants