Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Terminal::display_glyph_in_box cast_sign_loss and cast_possible_wrap #181

Closed
todo bot opened this issue Jan 23, 2019 · 2 comments · Fixed by #187
Closed

Review Terminal::display_glyph_in_box cast_sign_loss and cast_possible_wrap #181

todo bot opened this issue Jan 23, 2019 · 2 comments · Fixed by #187
Assignees
@Orycterope
Labels
todo 🗒️ Created by the todo bot

Comments

@todo
Copy link

todo bot commented Jan 23, 2019

Ping @Orycterope. I'm pretty sure they're correct but just want to make sure it looks good with you since it's originally your code.

https://github.com/roblabla42/KFS/blob/fbd5755c39fed372ed43ba3e0db19685396ee041/libuser/src/terminal.rs#L248-L258

This issue was generated by todo based on a TODO comment in fbd5755 when #88 was merged. cc @Orycterope.
@todo todo bot added the todo 🗒️ Created by the todo bot label Jan 23, 2019
@Orycterope
Copy link
Member

Not sure, but this function should be replaced by a real font rendering as soon as possible.

@roblabla
Copy link
Member

Needs a commit removing the TODO then.

@roblabla roblabla reopened this Jan 30, 2019
Orycterope added a commit to Orycterope/SunriseOS that referenced this issue Jan 31, 2019
@Orycterope
Removing terminal font todos
43fca6f 
Closes sunriseos#180 and closes sunriseos#181
@Orycterope Orycterope mentioned this issue Jan 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Orycterope Orycterope

Labels
todo 🗒️ Created by the todo bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing terminal font todos Orycterope/SunriseOS
2 participants
@roblabla @Orycterope