Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NOAAIndices plot limits #5496

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Fix NOAAIndices plot limits #5496

merged 2 commits into from
Aug 25, 2021

Conversation

dstansby
Copy link
Member

Fixes #5357. Because there are lots of NaNs in the files, and pandas will set the x-limits including these, the solution is to manually set the x-limits ignoring the NaNs. I also did a bit of refactoring to make the code nicer.

@dstansby dstansby requested a review from a team as a code owner August 11, 2021 15:08
@dstansby dstansby added the timeseries Affects the timeseries submodule label Aug 11, 2021
@dstansby dstansby added the Needs Review Needs reviews before merge. label Aug 18, 2021
@nabobalis nabobalis merged commit b7fece0 into sunpy:main Aug 25, 2021
@sunpy-backport
Copy link

The backport to 3.0 failed:

Commits ["82e3fb08443a01d3d55f5645bf62367578d10a6b","5ee0ddd52e31f3057dcac6afa240ef61adb1c167"] could not be cherry-picked on top of 3.0

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport 3.0
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 82e3fb08443a01d3d55f5645bf62367578d10a6b 5ee0ddd52e31f3057dcac6afa240ef61adb1c167
# Create a new branch with these backported commits.
git checkout -b backport-5496-to-3.0
# Push it to GitHub.
git push --set-upstream origin backport-5496-to-3.0
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is 3.0 and the compare/head branch is backport-5496-to-3.0.

@nabobalis nabobalis added the Still Needs Manual Backport This PR needs manually backporting. label Aug 25, 2021
@dstansby dstansby deleted the noaa-plot-limits branch August 25, 2021 16:13
dstansby pushed a commit to dstansby/sunpy that referenced this pull request Oct 11, 2021
@dstansby dstansby mentioned this pull request Oct 11, 2021
@nabobalis nabobalis removed the Still Needs Manual Backport This PR needs manually backporting. label Oct 11, 2021
@dstansby dstansby removed the Needs Review Needs reviews before merge. label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
timeseries Affects the timeseries submodule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axes limits on NOAA SWPC plot in docs are not ideal
2 participants