-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registers package with sunpy template #159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaloney
reviewed
Jul 17, 2024
CyclingNinja
force-pushed
the
register_template
branch
4 times, most recently
from
July 22, 2024 15:29
81e6963
to
4f95299
Compare
samaloney
force-pushed
the
register_template
branch
2 times, most recently
from
July 24, 2024 23:17
751a0d8
to
a9d8b8c
Compare
Can this PR be updated with the most recent upstream changes from the template? |
Cadair
force-pushed
the
register_template
branch
from
October 15, 2024 15:02
a9d8b8c
to
4bef009
Compare
Cadair
reviewed
Oct 15, 2024
I think this should be good for another look from everyone. |
samaloney
reviewed
Oct 16, 2024
samaloney
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Co-authored-by: Shane Maloney <[email protected]>
DanRyanIrish
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.