Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASDA into sunkit-image #40

Merged
merged 5 commits into from
Dec 22, 2019
Merged

Add ASDA into sunkit-image #40

merged 5 commits into from
Dec 22, 2019

Conversation

PyDL
Copy link

@PyDL PyDL commented Dec 3, 2019

Add ASDA into sunkit-image

Description

First attempt to integrate ASDA into sunkit-image

@pep8speaks
Copy link

pep8speaks commented Dec 3, 2019

Hello @PyDL! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-22 12:43:03 UTC

@ghost
Copy link

ghost commented Dec 3, 2019

Thanks for the pull request @PyDL! Everything looks great!

@nabobalis nabobalis added this to the v0.1.0 milestone Dec 3, 2019
@nabobalis
Copy link
Contributor

Thanks @PyDL, I will go through it and probably update it to follow our coding standards! I'll try to get it in for the next release.

@nabobalis nabobalis added [WIP] Feature Request New feature wanted! labels Dec 3, 2019
@PyDL
Copy link
Author

PyDL commented Dec 5, 2019

Thanks @PyDL, I will go through it and probably update it to follow our coding standards! I'll try to get it in for the next release.

@nabobalis Thank you. Please let me know if anything is needed.

@nabobalis
Copy link
Contributor

I'll get onto this on Saturday

This was referenced Dec 8, 2019
@nabobalis
Copy link
Contributor

@PyDL I havn't finished (need to do the tests and example next) but you can see the changes I have made to the main ASDA code in the last commit.

I have just moved some things around and tidied up the code otherwise nothing has changed.

@nabobalis
Copy link
Contributor

I've changed the tests to check for values, now I just need to get the example to be functional.

@nabobalis nabobalis removed the [WIP] label Dec 22, 2019
@nabobalis nabobalis merged commit b3f4bfb into sunpy:master Dec 22, 2019
@nabobalis
Copy link
Contributor

Thanks @PyDL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature wanted!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants