Converting between negative data and wcs axes. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @DanRyanIrish! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on March 14, 2018 at 12:46 Hours UTC |
DanRyanIrish
force-pushed
the
data_to_wcs_axis_fix
branch
from
4eea081 to
ebf5e7f
Compare
Also add checks to those functions to catch axis numbers out of range.
DanRyanIrish
force-pushed
the
data_to_wcs_axis_fix
branch
from
ebf5e7f to
a86df69
Compare
DanRyanIrish
added a commit
that referenced
this pull request
Mar 20, 2018
Converting between negative data and wcs axes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses bugs highlighted by Issue #85 in converting between data and wcs axis numbers on an
NDCubewhen the axis number is negative. This is fixed by first converting the negative axis number to the corresponding positive one and then performing the conversion.