Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change NDCube(Sequence) reprs to __str__ #242

Merged
merged 5 commits into from
Mar 27, 2020

Conversation

DanRyanIrish
Copy link
Member

@DanRyanIrish DanRyanIrish commented Mar 23, 2020

Description

Fixes #

To Do:

  • Fix textwrap.dedent. Not working for NDCube.__str__

@DanRyanIrish DanRyanIrish requested a review from Cadair March 23, 2020 03:53
@DanRyanIrish
Copy link
Member Author

Following your suggestion on PR #238, I changed the NDCube and NDCubeSequence __repr__s to __str__. Is this desirable for these classes for the same reasons?

@DanRyanIrish DanRyanIrish added this to the 1.3 milestone Mar 23, 2020
@pep8speaks
Copy link

pep8speaks commented Mar 26, 2020

Hello @DanRyanIrish! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-03-27 13:34:36 UTC

ndcube/ndcube.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants