[Backport 1.2] Bugfix for Issue 218: NDCube slicing with numpy.int64 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sunpy-backport[bot]](https://avatars.githubusercontent.com/in/48001?s=60&v=4){kind=small}
If an axis after the first axis was sliced with a non-native int type, e.g. numpy.int64, the slixing would crash due to missing_axes not being altered. This commit adds support for nupy.int64 and numpy.int32 types.
|
@Cadair can this just be merged? Haven't dealt with a bot-opened backport before. |
|
treat it like any other PR. Are the fails the same as the other PRs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #223.