Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix explicit axes argument for 2D plots #204

Merged
merged 5 commits into from
Sep 10, 2019
Merged

Fix explicit axes argument for 2D plots #204

merged 5 commits into from
Sep 10, 2019

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Sep 10, 2019

Fixes #192

@pep8speaks
Copy link

pep8speaks commented Sep 10, 2019 •
edited
Loading

Hello @Cadair! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-09-10 17:19:54 UTC

@ghost
Copy link

ghost commented Sep 10, 2019 •
edited by ghost
Loading

Thanks for the pull request @Cadair! Everything looks great!

@Cadair Cadair requested a review from DanRyanIrish September 10, 2019 14:41
@Cadair Cadair added this to the 1.2 milestone Sep 10, 2019
@Cadair Cadair merged commit d8f4c27 into sunpy:master Sep 10, 2019
@Cadair Cadair deleted the wcsaxes-2d branch September 10, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanRyanIrish DanRyanIrish DanRyanIrish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

2D plot fails when passing a WCSAxes
3 participants
@Cadair @pep8speaks @DanRyanIrish